tidy round1

parasitics/ConcreteParasitics.cc

@@ -752,8 +752,8 @@ NetIdPairLess::operator()(const NetIdPair &net_id1,
 
 ////////////////////////////////////////////////////////////////
 
-ConcreteParasitics::ConcreteParasitics(std::string name,
-                                       std::string filename,
+ConcreteParasitics::ConcreteParasitics(std::string_view name,
+                                       std::string_view filename,
                                        StaState *sta) :
   Parasitics(sta),
   name_(name),
@@ -1439,4 +1439,4 @@ ConcreteParasitics::unannotatedLoads(const Parasitic *parasitic,
   return cparasitic->unannotatedLoads(drvr_pin, this);
 }
 
-} // namespace
+} // namespace sta

parasitics/ConcreteParasitics.hh

@@ -50,10 +50,10 @@ using ConcreteParasiticNetworkMap = std::map<const Net*, ConcreteParasiticNetwor
 class ConcreteParasitics : public Parasitics
 {
 public:
-  ConcreteParasitics(std::string name,
-                     std::string filename,
+  ConcreteParasitics(std::string_view name,
+                     std::string_view filename,
                      StaState *sta);
-  virtual ~ConcreteParasitics();
+  ~ConcreteParasitics() override;
   const std::string &name() const override { return name_; };
   const std::string &filename() const override { return filename_; };
   bool haveParasitics() override;
@@ -202,4 +202,4 @@ protected:
   friend class ConcreteParasiticNetwork;
 };
 
-} // namespace
+} // namespace sta

parasitics/ConcreteParasiticsPvt.hh

@@ -336,4 +336,4 @@ public:
                              ConcreteParasiticNode *node2);
 };
 
-} // namespace
+} // namespace sta

parasitics/EstimateParasitics.cc

@@ -239,4 +239,4 @@ instanceArea(Instance *inst,
 }
 #endif
 
-} // namespace
+} // namespace sta

parasitics/EstimateParasitics.hh

@@ -95,4 +95,4 @@ protected:
                                 bool &elmore_use_load_cap);
 };
 
-} // namespace
+} // namespace sta

parasitics/ReduceParasitics.cc

@@ -688,4 +688,4 @@ ReduceToPiPoleResidue2::findPolesResidues(Parasitic *pi_pole_residue,
   }
 }
 
-} // namespace
+} // namespace sta

parasitics/ReduceParasitics.hh

@@ -55,4 +55,4 @@ reduceToPiPoleResidue2(const Parasitic *parasitic_network,
                        const MinMax *min_max,
                        StaState *sta);
 
-} // namespace
+} // namespace sta

parasitics/ReportParasiticAnnotation.hh

@@ -36,4 +36,4 @@ reportParasiticAnnotation(Parasitics *parasitics,
                           const Scene *scene,
                           StaState *sta);
 
-} // namespace
+} // namespace sta

parasitics/SpefNamespace.cc

@@ -114,4 +114,4 @@ staToSpef(std::string_view sta_name,
   return spef_name;
 }
 
-} // namespace
+} // namespace sta

parasitics/SpefNamespace.hh

@@ -42,4 +42,4 @@ staToSpef(std::string_view sta_name,
           char path_divider,
           char path_escape);
 
-} // namespace
+} // namespace sta

parasitics/SpefReader.cc

@@ -101,8 +101,6 @@ SpefReader::SpefReader(std::string_view filename,
   parasitics->setCouplingCapFactor(coupling_cap_factor);
 }
 
-SpefReader::~SpefReader() {}
-
 bool
 SpefReader::read()
 {

parasitics/SpefReader.hh

@@ -55,4 +55,4 @@ readSpefFile(std::string_view filename,
              Parasitics *parasirics,
              StaState *sta);
 
-} // namespace
+} // namespace sta

parasitics/SpefReaderPvt.hh

@@ -58,7 +58,7 @@ public:
              const MinMaxAll *min_max,
              Parasitics *parasitics,
              StaState *sta);
-  virtual ~SpefReader();
+  virtual ~SpefReader() = default;
   bool read();
   char divider() const { return divider_; }
   void setDivider(char divider);
@@ -181,4 +181,4 @@ private:
   SpefTriple *c1_;
 };
 
-} // namespace
+} // namespace sta

parasitics/SpefScanner.hh

@@ -46,8 +46,6 @@ public:
               std::string_view filename,
               SpefReader *reader,
               Report *report);
-  virtual ~SpefScanner() {}
-
   virtual int lex(SpefParse::semantic_type *const yylval,
                   SpefParse::location_type *yylloc);
   // YY_DECL defined in SpefLex.ll
@@ -66,4 +64,4 @@ private:
   std::string token_;
 };
 
-} // namespace
+} // namespace sta