According to ShellCheck's documentation:
export takes a variable name, but ShellCheck has noticed that you give it
an expanded variable instead. Remove $/${} for that, or use ${var?} to quiet.
Related: https://www.shellcheck.net/wiki/SC2163
Related: #470
Some variables, that were unquoted intentionally were converted to arrays.
According to ShellCheck's documentation:
Quoting variables prevents word splitting and glob expansion, and prevents
the script from breaking when input contains spaces, line feeds, glob
characters and such.
Related: https://www.shellcheck.net/wiki/SC2086
Related: #470
According to ShellCheck's documentation:
In the original code, the return value of mycmd in $(mycmd) is ignored,
and export will instead always return true. This may prevent conditionals,
set -e and traps from working correctly.
Related: https://www.shellcheck.net/wiki/SC2155
Related: #470
According to ShellCheck's documentation:
-a and -o in [ .. ] test expressions are not well defined, and can cause
incorrect results when arguments start with dashes or contain !.
Related: https://www.shellcheck.net/wiki/SC2166
Related: #470
Add --nagelfardatadir and --enable-nagelfar-addons installation option
to control whether or not Modules-specific Nagelfar files need to be
installed and in what location.
Introduce the --with-tcl-linter-opts configure option to choose at
installation time the options to pass to the tcl linter program. Default
option is ''.
Introduce the --with-tcl-linter configure option to choose at
installation time the default program command to use to lint
modulefiles. Default Tcl linter is 'nagelfar.tcl'.
Update configure script to better guess the libdir64 and libdir32
directory locations based on specified libdir.
Correctly guess these directories when libdir does not end with '64' but
contains '64' like in '/usr/lib64/environment-modules'.
Remove entirely the work on the noglob_eval_shells option as enclosing
in quotes the generated output of modulecmd.tcl to pass it to the eval
command is equivalent to disable the pathname expansion mechanism of
sh-kind shells.
Introduce the --with-noglob-eval-shells configure option to choose at
installation time if the pathname expansion should be disabled or not in
the module function to evaluate shell code produced by modulecmd.tcl,
for the shells listed in option value.
Add the --with-fishcompletiondir option to the configure installation
script to define a particular installation directory for the fish
completion script.
If option is not defined, fish completion script is installed by default
in initdir and it is sourced in fish init script. If option is set,
completion script is installed in designated directory and fish init
script does not source it.
Add the --with-bashcompletiondir option to the configure installation
script to define a particular installation directory for the bash
completion script.
If option is not defined, bash completion script is installed by default
in initdir and it is sourced in bash init script. If option is set,
completion script is installed in designated directory and bash init
script does not source it.
Add the --with-zshcompletiondir option to the configure installation
script to define a particular installation directory for the zsh
completion script.
If option is not defined, zsh completion script is installed by default
in initdir and the FPATH environment variable is set in zsh init script.
If option is set, completion script is installed in designated directory
and zsh init script does not set the FPATH environment variable.
Fixes#428
Change installation option --enable-silent-shell-debug-support to
disable it by default. Now the silent_shell_debug configuration option
enables to locally enable this feature from the initrc configuration
file.
Change installation option --enable-quarantine-support to disable it by
default. Now the quarantine_support configuration option enables to
locally enable this feature from the initrc configuration file.
Make --enable-modulespath the primary option name and
--enable-dotmodulespath the secondary option name as .modulespath is not
anymore the primary name of this configuration file.
Installation option '--with-initconf-in' is set to 'etdir' by default
to locate configuration files in the directory designated by the
'--etcdir' option. Therefore the initialization configuration file is
named `initrc` in this directory, and the modulepath-specific
configuration file is named `modulespath`.
Configuration files are thus located in a traditional etcdir rather
being part of the init dir among scripts that should stay read only.
Installation option '--enable-set-shell-startup' is set off by default
but could be enabled once installed through the `initrc` configuration
file.
It seems better to let people choose to enable this option than being
surprised to find Modules initialization script run automatically each
time a sub-shell is spawn.
Add the element `variant` in the allow list of the list_output and
list_terse_output configuration options. Set this new element in the
default value list of the list_output configuration option.
Introduce the --with-editor configure option to choose at installation
time the default editor command to use to interactively edit
modulefiles. Default editor is 'vi'.
Change license of the configure installation script from GPLv3+ to
GPLv2+.
Align this way all files from the Modules project under the GPLv2+
license.
Consent has been obtained from the copyright holders (I, @xdch47 and
@jraphanel) to perform such move. Consent from Jacques Raphanel and
Felix Neumärker were collected by email.
Revert contribution from R.K. Owen (cc4d3194), from whom consent is not
yet obtained. Contribution will be restored as soon as consent will be
obrained.
Related to #389
Add mcookie_version_check configuration to disable the version check on
the Modules magic cookie used in modulefiles. Option, enabled by
default, is linked to the MODULES_MCOOKIE_VERSION_CHECK environment
variable.
Closes#377.
Introduce --enable-new-features configure option to enable all at once
all the new features disabled by default due to the behavior change they
introduced on Modules 4.
--enable-new-features option is equivalent to --enable-auto-handling,
--enable-color, --with-icase=search, --enable-extended-default,
--enable-advanced-version-spec.
