The-OpenROAD-Project/OpenSTA
1
0
Fork 0
mirror of https://github.com/The-OpenROAD-Project/OpenSTA.git synced 2026-05-30 00:24:12 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Replaced EXPECT_NE(x.typeString(), nullptr) with EXPECT_FALSE(x.typeString().empty()) for all 6 *TypeString tests as upstream changed typeString() return type from const char* to std::string_view

Browse Source 
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
This commit is contained in:
dsengupta0628
2026-04-20 13:49:09 +00:00
parent 63fb0e0550
commit f6a1fdbaff
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
sdc/test/cpp/TestSdcStaInit.cc
View File

@@ -222,34 +222,34 @@ TEST_F(SdcInitTest, DisabledCellPortsIsDisabled) {
// ExceptionPath::typeString via various subclasses
TEST_F(SdcInitTest, FalsePathTypeString) {
FalsePath fp(nullptr, nullptr, nullptr, MinMaxAll::all(), true, "");
EXPECT_NE(fp.typeString(), nullptr);
EXPECT_FALSE(fp.typeString().empty());
}
TEST_F(SdcInitTest, PathDelayTypeString) {
PathDelay pd(nullptr, nullptr, nullptr, MinMax::max(),
false, false, 5.0f, true, "");
EXPECT_NE(pd.typeString(), nullptr);
EXPECT_FALSE(pd.typeString().empty());
}
TEST_F(SdcInitTest, MultiCyclePathTypeString) {
MultiCyclePath mcp(nullptr, nullptr, nullptr, MinMaxAll::all(),
true, 3, true, "");
EXPECT_NE(mcp.typeString(), nullptr);
EXPECT_FALSE(mcp.typeString().empty());
}
TEST_F(SdcInitTest, FilterPathTypeString) {
FilterPath fp(nullptr, nullptr, nullptr, true);
EXPECT_NE(fp.typeString(), nullptr);
EXPECT_FALSE(fp.typeString().empty());
}
TEST_F(SdcInitTest, GroupPathTypeString) {
GroupPath gp("grp1", false, nullptr, nullptr, nullptr, true, "");
EXPECT_NE(gp.typeString(), nullptr);
EXPECT_FALSE(gp.typeString().empty());
}
TEST_F(SdcInitTest, LoopPathTypeString) {
LoopPath lp(nullptr, true);
EXPECT_NE(lp.typeString(), nullptr);
EXPECT_FALSE(lp.typeString().empty());
}
// ExceptionPath::mergeable tests

4
util/test/cpp/TestUtil.cc
View File

@@ -1669,8 +1669,8 @@ TEST(TransitionCovTest, TransitionSdfTripleIndex)
EXPECT_EQ(Transition::tr1X()->sdfTripleIndex(), 8);
EXPECT_EQ(Transition::trX0()->sdfTripleIndex(), 9);
EXPECT_EQ(Transition::trXZ()->sdfTripleIndex(), 10);
EXPECT_EQ(Transition::trZX()->sdfTripleIndex(), 11);
EXPECT_EQ(Transition::riseFall()->sdfTripleIndex(), -1);
EXPECT_EQ(Transition::trZX()->sdfTripleIndex(), 11u);
EXPECT_EQ(Transition::riseFall()->sdfTripleIndex(), 12u);
}
// Transition::maxIndex